Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build-release-yamls target #42

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

msherif1234
Copy link
Contributor

this target needs to be done in bpfman repo instead of bpfman-operator

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.39%. Comparing base (5b85c5d) to head (69aa11b).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/bpfman-agent/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   27.40%   27.39%   -0.02%     
==========================================
  Files          81       81              
  Lines        6965     6968       +3     
==========================================
  Hits         1909     1909              
- Misses       4870     4873       +3     
  Partials      186      186              
Flag Coverage Δ
unittests 27.39% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msherif1234 msherif1234 changed the title remove build-release-yamls target update build-release-yamls target Jul 10, 2024
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
Copy link
Contributor

@anfredette anfredette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 18fc34c into bpfman:main Jul 10, 2024
10 checks passed
msherif1234 pushed a commit to msherif1234/bpfman-operator that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants