Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new tool wakesnoop #3

Merged
merged 1 commit into from
Jan 21, 2025
Merged

new tool wakesnoop #3

merged 1 commit into from
Jan 21, 2025

Conversation

makelinux
Copy link
Contributor

@makelinux makelinux commented Apr 4, 2024

wakesnoop attaches to scheduler tracepoints sched_waking and sched_wakeup, and measures delay of wakeup.

Copy link
Member

@ajor ajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution - I'm sure we will be merging it at some point soon.

I'm just putting a temporary block on it while we have a discussion about licences for this new repository.

Copy link
Member

@ajor ajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting back to you. We should have sorted out our contribution guidelines before opening up this repository, but I think we're almost there now.

We're going to request that new scripts be licensed under a GPLv2-compatible license so that they are able to use the full BPF functionality by calling into GPL-only functions in the Linux kernel.

The list of accepted licenses is described in the kernel docs here: https://docs.kernel.org/process/license-rules.html#id1

  • GPL v2
  • Dual MIT/GPL v2
  • Dual BSD/GPL v2
  • Dual MPL/GPL v2

We're also going to start using SPDX identifiers to avoid large license boilerplate. An example would be:

// SPDX-License-Identifier: GPL-2.0-or-later

or:

// SPDX-License-Identifier: MIT OR GPL-2.0-or-later

sched/wakesnoop.bt Outdated Show resolved Hide resolved
@makelinux makelinux force-pushed the wakesnoop branch 2 times, most recently from 98de28c to 1f305dc Compare June 2, 2024 12:26
@makelinux makelinux requested a review from ajor August 27, 2024 19:10
@makelinux makelinux force-pushed the wakesnoop branch 2 times, most recently from 0014cf1 to e034b50 Compare January 20, 2025 19:02
@makelinux makelinux marked this pull request as draft January 21, 2025 03:30
@makelinux makelinux force-pushed the wakesnoop branch 3 times, most recently from b9dcc60 to f28e2ae Compare January 21, 2025 13:16
wakesnoop attaches to scheduler tracepoints sched_waking and sched_wakeup,
and measures delay of wakeup.

Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
@makelinux makelinux marked this pull request as ready for review January 21, 2025 13:19
@makelinux
Copy link
Contributor Author

@ajor, would you like to review please?

Copy link
Contributor

@jordalgo jordalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new user-tool!

@jordalgo jordalgo merged commit 7a3899b into bpftrace:master Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants