fix: prevent table component from breaking with invalid data #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsgoulart
force-pushed
the
1337-validate-table-data
branch
from
4071441 to
67dcafc
Compare
vsgoulart
commented
Dec 18, 2024
| @@ -45,7 +45,9 @@ export function Table(props) { | |||
| const evaluatedColumns = useEvaluatedColumns(columnsExpression || '', columns); | |||
| const columnKeys = evaluatedColumns.map(({ key }) => key); | |||
| const evaluatedDataSource = useExpressionEvaluation(dataSource); | |||
| const data = Array.isArray(evaluatedDataSource) ? evaluatedDataSource.filter((i) => i !== undefined) : []; | |||
| const data = Array.isArray(evaluatedDataSource) | |||
There was a problem hiding this comment.
I couldn't really find a way to test this. Karma didn't throw any errors and it would render an empty table.
If you have any ideas let me know.
vsgoulart
force-pushed
the
1337-validate-table-data
branch
from
67dcafc to
cc6a696
Compare
Skaiir
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filters out invalid data from the table component which would make it break the entire editor if it happened.
Closes #1337
form-jselement or visually changes an existing component.