Focus the context menu after the position is set #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the jump of the table when the context menu was opened in a scrolled table. Previously, the focus was set on a context menu positioned in the top left corner of the table which forced the browser to scroll the position to the top left corner. Then, the position of the context menu was correctly set, but the scroll position was already changed. Now, the context menu is positioned correctly first and only then can it be focused. Related to camunda/camunda-modeler#1433
barmac
force-pushed
the
first-position-the-context-menu-and-then-focus-it
branch
from
5ebb4c3 to
0f7708f
Compare
barmac
changed the title
barmac
changed the title
|
Thank you 🦊 |
barmac
force-pushed
the
first-position-the-context-menu-and-then-focus-it
branch
2 times, most recently
from
c144f27 to
0f7708f
Compare
|
I looked more into this and it seems that the Firefox test failure is caused by a bug in the browser. Even with Firefox 70 the test fails. On the other hand, the bug is gone when tested manually. |
|
If that is the case we could exclude the failing spec on Firefox. This should be a rare thing to do. And please document it / link to related issues you've found along with the skip. |
barmac
added a commit
that referenced
this pull request
Oct 23, 2019
Firefox inconsistently fires focus events which causes the tests to fail but in real usage autofocus works correctly. Cf. #25 and linked sources
barmac
force-pushed
the
first-position-the-context-menu-and-then-focus-it
branch
from
2672e39 to
f29287d
Compare
Firefox inconsistently fires focus events which causes the tests to fail but in real usage autofocus works correctly. Cf. #25 and linked sources
barmac
force-pushed
the
first-position-the-context-menu-and-then-focus-it
branch
from
f29287d to
6e21af2
Compare
|
@philippfromme Firefox will no more test the cases where it failed to focus correctly. Please feel free to review now. |
fake-join
bot
deleted the
first-position-the-context-menu-and-then-focus-it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the jump of the table when the context menu was opened
in a scrolled table. Previously, the focus was set on a context menu
positioned in the top left corner of the table which forced the browser
to scroll the position to the top left corner. Then, the position
of the context menu was correctly set, but the scroll position
was already changed.
Now, the context menu is positioned correctly first and only then
can it be focused.
Related to camunda/camunda-modeler#1433