Make it clearer how to free up the hardware serial for debugging. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On boards with only one hardware serial interface, some users connect the ESP8266 through the hardware serial because it provides the fastest connection to the ESP8266. However, by default this hardware serial port is used for logging. It can be freed up by defining a custom log facility (together with alternative definitions of LOGERROR, LOGDEBUG etc.).
|
Actually defining LOGERROR outside of WiFiEsp does not seem to work. The only solution seems to be to pass the actual stream to WiFiEsp/WiFiEspClient/WiFiEspServer/EspDrv. |
|
Works for me, you'd need define it in the same place where you'd define ESPCUSTOMLOGFACILITY. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On boards with only one hardware serial interface, some users connect the ESP8266 through the hardware serial because it provides the fastest connection to the ESP8266. However, by default this hardware serial port is used for logging. These users need a custom logging facility.
Users that need the hardware serial port can free it up by defining
_ESPCUSTOMLOGFACILITY_, and by providing user-defined alternatives toLOGERROR,LOGDEBUGetc. either indebug.h, or in a separate user header file.Closes #84.