Merge pull request #100 from GouthamShiv/patch-1

update to feedback selection logic
bradtraversy · Feb 2, 2022 · cd228d5 · cd228d5
2 parents 4e8ebf4 + 6ca6079
commit cd228d5
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/feedback-ui-design/script.js b/feedback-ui-design/script.js
@@ -5,15 +5,18 @@ const panel = document.querySelector('#panel')
 let selectedRating = 'Satisfied'
 
 ratingsContainer.addEventListener('click', (e) => {
-    if(e.target.parentNode.classList.contains('rating')) {
+    if(e.target.parentNode.classList.contains('rating') && e.target.nextElementSibling) {
         removeActive()
         e.target.parentNode.classList.add('active')
         selectedRating = e.target.nextElementSibling.innerHTML
-    }
-    if(e.target.classList.contains('rating')) {
+    } else if(
+        e.target.parentNode.classList.contains('rating') &&
+        e.target.previousSibling &&
+        e.target.previousElementSibling.nodeName === 'IMG'
+    ) {
         removeActive()
-        e.target.classList.add('active')
-        selectedRating = e.target.nextElementSibling.innerHTML
+        e.target.parentNode.classList.add('active')
+        selectedRating = e.target.innerHTML
     }
 
 })
@@ -32,4 +35,4 @@ function removeActive() {
     for(let i = 0; i < ratings.length; i++) {
         ratings[i].classList.remove('active')
     }
-}
+}