Skip to content

removing the category edit from sheets_converter #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djarecka wants to merge 1 commit into
base: main
Choose a base branch
from
Open

removing the category edit from sheets_converter #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions bkbit/model_converters/sheets_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,17 +119,8 @@ def bican_fix(schema: SchemaDefinition) -> SchemaDefinition:
"""
Apply BICAN specific fixes to the schema
:param schema:
:return:
:return: SchemaDefinition
"""
# fixing values for categories
for nm, cl in schema.classes.items():
if "category" in cl.slots:
cl.slot_usage["category"] = SlotDefinition(name="category", pattern=r"^bican:[A-Z][A-Za-z]+$")
# not needed anymore
# if "name_pr" in cl.slots:
# cl.slots["name"] = cl.slots.pop("name_pr")
# if "slot_usage" in cl and "name_pr" in cl["slot_usage"]:
# cl.slot_usage["name"] = cl.slot_usage.pop("name_pr")

# removing names from the slots
if "name" in schema.slots:
Expand Down