-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPS-1063: UAE Lite remove the instace of //phpcs:ignore WordPress.Security in the repo #1064
base: release-candidate
Are you sure you want to change the base?
Conversation
|
||
// If action coming from general settings page. | ||
if ( isset( $_POST['option_page'] ) && 'general' === $_POST['option_page'] ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing | ||
* Save analytics option to network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why code indentaions is always messed up?
echo $header_content; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped | ||
|
||
if ( ! empty( $header_content ) ) { | ||
echo wp_kses_post( $header_content ); // Properly escaped output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to confirm if the content is displaying correctly, prepare detailed testcases for this change
|
||
if ( ! empty( $footer_content ) ) { | ||
echo "<div class='footer-width-fixer'>"; | ||
echo wp_kses_post( $footer_content ); // Properly escaped output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments in the PR
Description
Improvement: Enhanced the codebase to strengthen security measures.
Screenshots
Types of changes
How has this been tested?
Checklist: