Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPS-1063: UAE Lite remove the instace of //phpcs:ignore WordPress.Security in the repo #1064

Open
wants to merge 2 commits into
base: release-candidate
Choose a base branch
from

Conversation

akshayurankar48
Copy link
Contributor

@akshayurankar48 akshayurankar48 commented Jan 30, 2025

Description

Improvement: Enhanced the codebase to strengthen security measures.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@akshayurankar48 akshayurankar48 changed the title sanitized fields EPS-1063: UAE Lite remove the instace of //phpcs:ignore WordPress.Security in the repo Jan 30, 2025

// If action coming from general settings page.
if ( isset( $_POST['option_page'] ) && 'general' === $_POST['option_page'] ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
* Save analytics option to network.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why code indentaions is always messed up?

echo $header_content; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped

if ( ! empty( $header_content ) ) {
echo wp_kses_post( $header_content ); // Properly escaped output
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to confirm if the content is displaying correctly, prepare detailed testcases for this change


if ( ! empty( $footer_content ) ) {
echo "<div class='footer-width-fixer'>";
echo wp_kses_post( $footer_content ); // Properly escaped output
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

Copy link
Collaborator

@sushmak02 sushmak02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants