Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rc #753

Merged
merged 18 commits into from
Jan 3, 2024
Merged

Update rc #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f758dd5
Merge pull request #734 from brainstormforce/release-candidate
sushmak02 Nov 30, 2023
c754322
fixed header footer layout broken after last update
mahajanleena1995 Dec 1, 2023
c6e0256
phpcs
mahajanleena1995 Dec 1, 2023
dad9a2c
Removed affected code
sushmak02 Dec 1, 2023
795a908
Merge pull request #744 from brainstormforce/hot-fix
sushmak02 Dec 1, 2023
932ade4
Fixed flyout layout
vijetaR Dec 1, 2023
0683702
tag update and changelog added
vijetaR Dec 1, 2023
c276411
Merge pull request #746 from brainstormforce/nav-menu-fix
sushmak02 Dec 1, 2023
27d6782
Fixed logo width not applying issue
sushmak02 Dec 4, 2023
8ba6c40
Merge branch 'master' of github.com:brainstormforce/header-footer-ele…
sushmak02 Dec 4, 2023
f04a39e
Updated version
sushmak02 Dec 4, 2023
11f3f58
Merge pull request #747 from brainstormforce/logo-fix
sushmak02 Dec 4, 2023
4a94c45
retina image url link
vijetaR Dec 10, 2023
bbd7c8f
Caption html elements
vijetaR Dec 10, 2023
01d3706
Tag updates and changelog
vijetaR Dec 10, 2023
b89bdc8
Updated changelog
vijetaR Dec 10, 2023
4bf7420
Merge pull request #750 from brainstormforce/retina-img-link
sushmak02 Dec 14, 2023
be06d2c
Removed extra space
sushmak02 Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
**Requires at least:** 4.4
**Requires PHP:** 5.4
**Tested up to:** 6.4.1
**Stable tag:** 1.6.18
**Stable tag:** 1.6.22
**License:** GPLv2 or later
**License URI:** http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -140,6 +140,18 @@ This same applies when you are creating your Header/Footer using this plugin.

## Changelog ##

### 1.6.22 ###
- Fix: Retina Image - Navigating to custom URL by clicking on images.

### 1.6.21 ###
- Fix: Site Logo - Width and height settings not applying to the logo.

### 1.6.20 ###
- Fix: Flyout menu not appearing correctly.

### 1.6.19 ###
- Fix: Header and Footer layout broken after last update.

### 1.6.18 ###
- Improvement: Compatibility with latest Elementor and Elementor Pro 3.18 version.
- Improvement: Compatibility with WordPress VIP Go rules.
Expand Down
4 changes: 2 additions & 2 deletions header-footer-elementor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@
* Author URI: https://www.brainstormforce.com/
* Text Domain: header-footer-elementor
* Domain Path: /languages
* Version: 1.6.18
* Version: 1.6.22
* Elementor tested up to: 3.18
* Elementor Pro tested up to: 3.18
*
* @package header-footer-elementor
*/

define( 'HFE_VER', '1.6.18' );
define( 'HFE_VER', '1.6.22' );
define( 'HFE_FILE', __FILE__ );
define( 'HFE_DIR', plugin_dir_path( __FILE__ ) );
define( 'HFE_URL', plugins_url( '/', __FILE__ ) );
Expand Down
8 changes: 4 additions & 4 deletions inc/class-header-footer-elementor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public function register_notices() {
'type' => '',
'message' => sprintf(
'<div class="notice-image">
<img src="%1$s" class="custom-logo" alt="Sidebar Manager" itemprop="logo"></div>
<img src="%1$s" class="custom-logo" alt="Sidebar Manager" itemprop="logo"></div>
<div class="notice-content">
<div class="notice-heading">
%2$s
Expand Down Expand Up @@ -508,15 +508,15 @@ public function setup_fallback_support() {
*/
public static function get_header_content() {
$header_content = self::$elementor_instance->frontend->get_builder_content_for_display( get_hfe_header_id() );
echo wp_kses_post( $header_content );
echo $header_content; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
}

/**
* Prints the Footer content.
*/
public static function get_footer_content() {
echo "<div class='footer-width-fixer'>";
echo wp_kses_post( self::$elementor_instance->frontend->get_builder_content_for_display( get_hfe_footer_id() ) );
echo self::$elementor_instance->frontend->get_builder_content_for_display( get_hfe_footer_id() ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
echo '</div>';
}

Expand All @@ -525,7 +525,7 @@ public static function get_footer_content() {
*/
public static function get_before_footer_content() {
echo "<div class='footer-width-fixer'>";
echo wp_kses_post( self::$elementor_instance->frontend->get_builder_content_for_display( hfe_get_before_footer_id() ) );
echo self::$elementor_instance->frontend->get_builder_content_for_display( hfe_get_before_footer_id() ); // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
echo '</div>';
}

Expand Down
4 changes: 2 additions & 2 deletions inc/widgets-manager/widgets/class-cart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ protected function render() {
<div class="hfe-cart-menu-wrap-default">
<?php if ( null !== WC()->cart ) { ?>
<span class="hfe-cart-count">
<?php echo esc_html( WC()->cart->get_cart_contents_count() ); ?>
<?php echo ( WC()->cart->get_cart_contents_count() ); ?>
</span>
<?php } ?>
</div>
Expand All @@ -643,7 +643,7 @@ protected function render() {
<a id="hfe-menu-cart__toggle_button" href="<?php echo esc_url( wc_get_cart_url() ); ?>" class="elementor-button hfe-cart-container">
<?php if ( null !== WC()->cart ) { ?>
<span class="elementor-button-text hfe-subtotal">
<?php echo wp_kses_post( WC()->cart->get_cart_subtotal() ); ?>
<?php echo WC()->cart->get_cart_subtotal(); ?>
</span>
<?php } ?>
<span class="elementor-button-icon" data-counter="<?php echo ( null !== WC()->cart ) ? esc_attr( WC()->cart->get_cart_contents_count() ) : ''; ?>">
Expand Down
7 changes: 3 additions & 4 deletions inc/widgets-manager/widgets/class-navigation-menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1952,7 +1952,7 @@
<div class="hfe-flyout-container">
<div id="hfe-flyout-content-id-<?php echo esc_attr( $this->get_id() ); ?>" class="hfe-side hfe-flyout-<?php echo esc_attr( $settings['flyout_layout'] ); ?> hfe-flyout-open" data-layout="<?php echo wp_kses_post( $settings['flyout_layout'] ); ?>" data-flyout-type="<?php echo wp_kses_post( $settings['flyout_type'] ); ?>">
<div class="hfe-flyout-content push">
<nav <?php echo wp_kses_post( $this->get_render_attribute_string( 'hfe-nav-menu' ) ); ?>><?php echo esc_html( $menu_html ); ?></nav>
<nav <?php echo wp_kses_post( $this->get_render_attribute_string( 'hfe-nav-menu' ) ); ?>><?php echo ( $menu_html ); ?></nav>

Check failure on line 1955 in inc/widgets-manager/widgets/class-navigation-menu.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$menu_html'.
<div class="elementor-clickable hfe-flyout-close" tabindex="0">
<?php echo isset( $menu_close_icons[1] ) ? $menu_close_icons[1] : ''; //phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped ?>
</div>
Expand Down Expand Up @@ -2016,7 +2016,7 @@
$this->add_render_attribute( 'hfe-nav-menu', 'data-full-width', $settings['full_width_dropdown'] );

?>
<div <?php echo wp_kses_post( $this->get_render_attribute_string( 'hfe-main-menu' ) ); ?>>
<div <?php echo $this->get_render_attribute_string( 'hfe-main-menu' ); ?>>
<div role="button" class="hfe-nav-menu__toggle elementor-clickable">
<span class="screen-reader-text"><?php esc_html_e( 'Menu', 'header-footer-elementor' ); ?></span>
<div class="hfe-nav-menu-icon">
Expand All @@ -2026,10 +2026,9 @@
?>
</div>
</div>
<nav <?php echo wp_kses_post( $this->get_render_attribute_string( 'hfe-nav-menu' ) ); ?>><?php echo wp_kses_post( $menu_html ); ?></nav>
<nav <?php echo $this->get_render_attribute_string( 'hfe-nav-menu' ); ?>><?php echo $menu_html; ?></nav>
</div>
<?php
}
}
}

6 changes: 3 additions & 3 deletions inc/widgets-manager/widgets/class-retina.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,12 +704,12 @@
}

?>
<div <?php echo esc_attr( $this->get_render_attribute_string( 'wrapper' ) ); ?>>
<div <?php echo ( $this->get_render_attribute_string( 'wrapper' ) ); ?>>

Check failure on line 707 in inc/widgets-manager/widgets/class-retina.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
<?php if ( $has_caption ) : ?>
<figure class="wp-caption">
<?php endif; ?>
<?php if ( $link ) : ?>
<a <?php echo esc_url( $this->get_render_attribute_string( 'link' ) ); ?>>
<a <?php echo ( $this->get_render_attribute_string( 'link' ) ); ?>>

Check failure on line 712 in inc/widgets-manager/widgets/class-retina.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
<?php endif; ?>
<?php
$size = $settings[ 'retina_image' . '_size' ];
Expand Down Expand Up @@ -804,7 +804,7 @@
?>
<?php if ( ! empty( $caption_text ) ) : ?>
<div class="hfe-caption-width">
<figcaption class="widget-image-caption wp-caption-text"><?php echo esc_html( $caption_text ); ?></figcaption>
<figcaption class="widget-image-caption wp-caption-text"><?php echo ( $caption_text ); ?></figcaption>

Check failure on line 807 in inc/widgets-manager/widgets/class-retina.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$caption_text'.
</div>
<?php endif; ?>
</figure>
Expand Down
8 changes: 4 additions & 4 deletions inc/widgets-manager/widgets/class-search-button.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,18 +982,18 @@
<form class="hfe-search-button-wrapper" role="search" action="<?php echo esc_url( home_url() ); ?>" method="get">
<?php if ( 'icon' === $settings['layout'] ) { ?>
<div class = "hfe-search-icon-toggle">
<input <?php echo wp_kses_post( $this->get_render_attribute_string( 'input' ) ); ?>>
<input <?php echo $this->get_render_attribute_string( 'input' ); ?>>

Check failure on line 985 in inc/widgets-manager/widgets/class-search-button.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
<i class="fas fa-search" aria-hidden="true"></i>
</div>
<?php } else { ?>
<div <?php echo wp_kses_post( $this->get_render_attribute_string( 'container' ) ); ?>>
<div <?php echo $this->get_render_attribute_string( 'container' ); ?>>

Check failure on line 989 in inc/widgets-manager/widgets/class-search-button.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
<?php if ( 'text' === $settings['layout'] ) { ?>
<input <?php echo wp_kses_post( $this->get_render_attribute_string( 'input' ) ); ?>>
<input <?php echo $this->get_render_attribute_string( 'input' ); ?>>

Check failure on line 991 in inc/widgets-manager/widgets/class-search-button.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
<button id="clear" type="reset">
<i class="fas fa-times clearable__clear" aria-hidden="true"></i>
</button>
<?php } else { ?>
<input <?php echo wp_kses_post( $this->get_render_attribute_string( 'input' ) ); ?>>
<input <?php echo $this->get_render_attribute_string( 'input' ); ?>>

Check failure on line 996 in inc/widgets-manager/widgets/class-search-button.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
<button id="clear-with-button" type="reset">
<i class="fas fa-times" aria-hidden="true"></i>
</button>
Expand Down
4 changes: 2 additions & 2 deletions inc/widgets-manager/widgets/class-site-logo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@
$class = 'elementor-clickable';
}
?>
<div <?php echo esc_attr( $this->get_render_attribute_string( 'wrapper' ) ); ?>>
<div <?php echo ( $this->get_render_attribute_string( 'wrapper' ) ); ?>>

Check failure on line 749 in inc/widgets-manager/widgets/class-site-logo.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
<?php if ( $has_caption ) : ?>
<figure class="wp-caption">
<?php endif; ?>
Expand All @@ -756,7 +756,7 @@
$class = 'elementor-non-clickable';
}
?>
<a data-elementor-open-lightbox="<?php echo esc_attr( $settings['open_lightbox'] ); ?>" class='<?php echo esc_attr( $class ); ?>' <?php echo wp_kses_post( $this->get_render_attribute_string( 'link' ) ); ?>>
<a data-elementor-open-lightbox="<?php echo esc_attr( $settings['open_lightbox'] ); ?>" class='<?php echo esc_attr( $class ); ?>' <?php echo $this->get_render_attribute_string( 'link' ); ?>>

Check failure on line 759 in inc/widgets-manager/widgets/class-site-logo.php

View workflow job for this annotation

GitHub Actions / CI (14.15, 7.4) 

All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$this'.
<?php endif; ?>
<?php
if ( empty( $site_image ) ) {
Expand Down
4 changes: 2 additions & 2 deletions languages/header-footer-elementor.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# This file is distributed under the same license as the Elementor Header & Footer Builder package.
msgid ""
msgstr ""
"Project-Id-Version: Elementor Header & Footer Builder 1.6.18\n"
"Project-Id-Version: Elementor Header & Footer Builder 1.6.22\n"
"Report-Msgid-Bugs-To: "
"https://wordpress.org/support/plugin/header-footer-elementor\n"
"POT-Creation-Date: 2023-11-30 07:08:53+00:00\n"
"POT-Creation-Date: 2023-12-10 18:13:21+00:00\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=utf-8\n"
"Content-Transfer-Encoding: 8bit\n"
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "header-footer-elementor",
"version": "1.6.18",
"version": "1.6.22",
"main": "Gruntfile.js",
"author": "Nikhil Chavan",
"devDependencies": {
Expand Down
14 changes: 13 additions & 1 deletion readme.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Donate link: https://www.paypal.me/BrainstormForce
Requires at least: 4.4
Requires PHP: 5.4
Tested up to: 6.4.1
Stable tag: 1.6.18
Stable tag: 1.6.22
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -140,6 +140,18 @@ This same applies when you are creating your Header/Footer using this plugin.

== Changelog ==

= 1.6.22 =
- Fix: Retina Image - Navigating to custom URL by clicking on images.

= 1.6.21 =
- Fix: Site Logo - Width and height settings not applying to the logo.

= 1.6.20 =
- Fix: Flyout menu not appearing correctly.

= 1.6.19 =
- Fix: Header and Footer layout broken after last update.

= 1.6.18 =
- Improvement: Compatibility with latest Elementor and Elementor Pro 3.18 version.
- Improvement: Compatibility with WordPress VIP Go rules.
Expand Down
Loading