Conversation
| uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: '8' | ||
| java-version: '17' |
There was a problem hiding this comment.
Is Java 17 required to compile card form now? Is this a breaking change then?
There was a problem hiding this comment.
It might be I don't see an explicit Java version specified in the build.gradle. I updated the build.gradle file to make it explicit.
There was a problem hiding this comment.
I guess I'm trying to understand - can we support Android 15 without bumping the java version? Or are we doing a major version of card form here? I more so am concerned that this change will force a major version in drop-in which I don't think we want to do yet
There was a problem hiding this comment.
Oh got it yeah I forgot DropIn doesn't use v5 yet. AGP uses JDK 17 to build, but we can set sourceCompatability to Java 8 and it should be fine.
| } | ||
|
|
||
| compileOptions { | ||
| sourceCompatibility versions.javaSourceCompatibility |
There was a problem hiding this comment.
Should this be Java 8 instead?
There was a problem hiding this comment.
Yeah it's 8 I made the change here: b0d4a3d
Co-authored-by: Sarah Koop <skoop@paypal.com>
3 participants
Summary of changes
Checklist
Authors