Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QL] Update PayPalWebCheckoutViewController for E2E App Switch Testing #1261

Merged
merged 2 commits into from
Apr 8, 2024
Merged

[QL] Update PayPalWebCheckoutViewController for E2E App Switch Testing #1261

merged 2 commits into from
Apr 8, 2024

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

  • Update button name from universalLinkButton to payPalAppSwitchButton
    • Update button text to "PayPal App Switch Flow"
  • Update method name from universalLinkFlow to tappedPayPalAppSwitchFlow
    • Address TODO
    • Handle nonce an errors for this flow - NOTE: this will not work yet but prepares us for stage and end to end stage testing early next week

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner April 8, 2024 13:54
@jaxdesmarais jaxdesmarais merged commit cbb664e into paypal-app-switch-feature Apr 8, 2024
6 of 7 checks passed
@jaxdesmarais jaxdesmarais deleted the handle-app-switch-nonce branch April 8, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@agedd agedd agedd approved these changes

@richherrera richherrera richherrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaxdesmarais @sshropshire @agedd @richherrera