Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QL] Stricter Logic For BA Token for App Switch #1274

Merged
merged 10 commits into from
Apr 24, 2024
Merged

[QL] Stricter Logic For BA Token for App Switch #1274

merged 10 commits into from
Apr 24, 2024

Conversation

jaxdesmarais
Copy link
Contributor

@jaxdesmarais jaxdesmarais commented Apr 15, 2024 •
edited
Loading

Summary of changes

  • Previous PR comment: https://github.com/braintree/braintree_ios/pull/1265/files#r1562730080
  • For the PayPal App Switch we only ever want a BA token currently, separate out logic to check only for BA token in this flow
  • Check that BA Token is present before attempting to start the App Switch flow, if not throw an error
  • Add new BTPayPalError.missingBAToken
  • Add unit test for this updated logic

Checklist

  • [ ] Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais requested a review from a team as a code owner April 15, 2024 14:28
agedd
agedd approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@jaxdesmarais @scannillo
Update UnitTests/BraintreePayPalTests/BTPayPalClient_Tests.swift
f7ed71e 
Co-authored-by: scannillo <35243507+scannillo@users.noreply.github.com>
@jaxdesmarais jaxdesmarais merged commit e50ac38 into paypal-app-switch-feature Apr 24, 2024
7 checks passed
@jaxdesmarais jaxdesmarais deleted the app-switch-flow-ba-only branch April 24, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdchow tdchow tdchow left review comments

@scannillo scannillo scannillo approved these changes

@agedd agedd agedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaxdesmarais @tdchow @scannillo @agedd