Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userAuthenticationEmail to 1-Time Checkout #1276

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

scannillo
Copy link
Contributor

@scannillo scannillo commented Apr 18, 2024

Background

Summary of changes

Demo UI

Screenshot 2024-04-18 at 11 13 39 AM

Checklist

  • Added a changelog entry

Authors

@scannillo

CHANGELOG.md Outdated Show resolved Hide resolved
Sources/BraintreePayPal/BTPayPalCheckoutRequest.swift Outdated Show resolved Hide resolved
@scannillo scannillo marked this pull request as ready for review April 19, 2024 15:55
@scannillo scannillo requested a review from a team as a code owner April 19, 2024 15:55
@scannillo scannillo force-pushed the user-email-pp-checkout branch from 5313939 to 0e0aa99 Compare April 19, 2024 15:57
@scannillo scannillo changed the base branch from main to payment-insights-feature April 19, 2024 18:30
@scannillo scannillo force-pushed the user-email-pp-checkout branch from 0e0aa99 to 1f2af56 Compare April 19, 2024 18:40
@scannillo scannillo force-pushed the user-email-pp-checkout branch from acf1baa to 87f65b5 Compare April 19, 2024 18:49
@scannillo
Copy link
Contributor Author

Update the base branch to be for the ShopperInsights feature based on convos that E2E testers will be testing this alongside ShopperInsights and the 2 features are "planned" to be released together.

@sarahkoop
Copy link
Contributor

Are we seeing the same success in sand and error in prod as we are on Android?

@scannillo
Copy link
Contributor Author

Are we seeing the same success in sand and error in prod as we are on Android?

I'm seeing this work in sandbox, but am not seeing the email prefill in production. I don't see a specific error in production though. @tdchow - what error in prod are you seeing?

// MARK: - Public Properties

/// Optional: User email to initiate a quicker authentication flow in cases where the user has a PayPal Account with the same email.
public var userAuthenticationEmail: String?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making sure, did we mean to remove the userAuthenticationEmail from BTPayPalNativeCheckoutRequest

Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@sarahkoop
Copy link
Contributor

Are we seeing the same success in sand and error in prod as we are on Android?

I'm seeing this work in sandbox, but am not seeing the email prefill in production. I don't see a specific error in production though. @tdchow - what error in prod are you seeing?

Confirmed it's expected to not be passed in prod currently (prod has not been released) - should not block merging this PR, we will hold on the full feature merge/release until this is rolled out in prod

@scannillo scannillo merged commit b5ad5ea into payment-insights-feature Apr 24, 2024
7 checks passed
@scannillo scannillo deleted the user-email-pp-checkout branch April 24, 2024 16:08
@tdchow
Copy link

tdchow commented Apr 25, 2024

I'm seeing this work in sandbox, but am not seeing the email prefill in production. I don't see a specific error in production though. @tdchow - what error in prod are you seeing?

Apologies! I wasn't seeing a specific error, but I was not seeing email prefilled in the live environment, same as iOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants