-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add userAuthenticationEmail
to 1-Time Checkout
#1276
Conversation
Demo/Application/Features/PayPalWebCheckoutViewController.swift
Outdated
Show resolved
Hide resolved
Demo/Application/Features/PayPalWebCheckoutViewController.swift
Outdated
Show resolved
Hide resolved
5313939
to
0e0aa99
Compare
0e0aa99
to
1f2af56
Compare
…ld to PP Web Demo
acf1baa
to
87f65b5
Compare
Update the base branch to be for the ShopperInsights feature based on convos that E2E testers will be testing this alongside ShopperInsights and the 2 features are "planned" to be released together. |
Demo/Application/Features/PayPalWebCheckoutViewController.swift
Outdated
Show resolved
Hide resolved
Demo/Application/Features/PayPalWebCheckoutViewController.swift
Outdated
Show resolved
Hide resolved
Are we seeing the same success in sand and error in prod as we are on Android? |
I'm seeing this work in sandbox, but am not seeing the email prefill in production. I don't see a specific error in production though. @tdchow - what error in prod are you seeing? |
// MARK: - Public Properties | ||
|
||
/// Optional: User email to initiate a quicker authentication flow in cases where the user has a PayPal Account with the same email. | ||
public var userAuthenticationEmail: String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making sure, did we mean to remove the userAuthenticationEmail
from BTPayPalNativeCheckoutRequest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚀
Confirmed it's expected to not be passed in prod currently (prod has not been released) - should not block merging this PR, we will hold on the full feature merge/release until this is rolled out in prod |
Apologies! I wasn't seeing a specific error, but I was not seeing email prefilled in the live environment, same as iOS. |
Background
Summary of changes
userAuthenticationEmail
property toBTPayPalCheckoutRequest
Demo UI
Checklist
Authors
@scannillo