Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V7] Update workflows to use Xcode 16.2.0 + Swift Version 5.10 #1501

Merged
merged 16 commits into from
Jan 22, 2025

Conversation

richherrera
Copy link
Contributor

@richherrera richherrera commented Jan 14, 2025

Summary of changes

  • Update all workflow to use Xcode 16.2.0 (resource)
  • Bump up Package.swift and Braintree.podspec to use Swift 5.10
  • Update CHANGELOG, Migration guide and Readme

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@richherrera richherrera requested a review from a team as a code owner January 14, 2025 21:33
@richherrera richherrera changed the title Update workflows to use Xcode 16.0 + Swift Version 5.10 [V7] Update workflows to use Xcode 16.0 + Swift Version 5.10 Jan 14, 2025
@richherrera richherrera changed the title [V7] Update workflows to use Xcode 16.0 + Swift Version 5.10 [V7] Update workflows to use Xcode 16.2.0 + Swift Version 5.10 Jan 14, 2025
@richherrera richherrera marked this pull request as draft January 15, 2025 14:51
@richherrera richherrera self-assigned this Jan 15, 2025
@richherrera richherrera marked this pull request as ready for review January 15, 2025 20:03
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that this is also listed in the README.md so we can update there too. Can also move it above the announcements since that section isn't really part of the SSL change.

@richherrera
Copy link
Contributor Author

Missed that this is also listed in the README.md so we can update there too. Can also move it above the announcements since that section isn't really part of the SSL change.

Readme updated: 08b637e

@jaxdesmarais
Copy link
Contributor

Do we want to make a separate ticket to address the UI tests failing? I'm fine with that just want to make sure we are able to tackle it.

@richherrera
Copy link
Contributor Author

Do we want to make a separate ticket to address the UI tests failing? I'm fine with that just want to make sure we are able to tackle it.

Sure, I've created a ticket to keep track of this DTMOBILES-1372

@richherrera richherrera merged commit 86d9d40 into v7 Jan 22, 2025
6 of 7 checks passed
@richherrera richherrera deleted the update-worlflows-swift-version branch January 22, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants