use locale.time_format for displaying time #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Dec 9, 2023
| @@ -150,10 +151,10 @@ class WeatherCard extends LitElement { | |||
| return html` | |||
| <ha-card @click="${this._handleClick}"> | |||
| ${this._config.current !== false ? this.renderCurrent(stateObj) : ""} | |||
| ${this._config.details !== false ? this.renderDetails(stateObj, lang) : ""} | |||
| ${this._config.details !== false ? this.renderDetails(stateObj, lang, time_format) : ""} | |||
There was a problem hiding this comment.
We should pass hass.locale here
There was a problem hiding this comment.
That can also work, but in HA there is a time format setting that can override system locale . If it's set, i think it should use time_formwt, then fallback to locale, and then to hass.lang.
There was a problem hiding this comment.
would be nice if this can be merged. I use an english OS, dutch locale. Logbook and history shows 24hr timeformat, unfortunately this card does not and gives me AM/PM times. It gives me headaches 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated toLocaleTimeString to use hass.locale.time_format with fallback to hass.language.
it's very useful for users that have English language selected but want to see 24h time display.