Skip to content

Commit

Permalink
Update existing brave://settings patches and add new ones to satisfy …
Browse files Browse the repository at this point in the history
…type checking
  • Loading branch information
emerick committed Jan 6, 2025
1 parent 86f88a8 commit 5272a71
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
4 changes: 2 additions & 2 deletions patches/chrome-browser-resources-settings-router.ts.patch
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
diff --git a/chrome/browser/resources/settings/router.ts b/chrome/browser/resources/settings/router.ts
index afe6eb3c611c80833e7ceaa32368a45cf8f2dcad..9e2ae5933cb523c0cf5ab48f5bb4218abd251c42 100644
index afe6eb3c611c80833e7ceaa32368a45cf8f2dcad..f714d77dd58abb5aafa3495c7e48ff9f71431a98 100644
--- a/chrome/browser/resources/settings/router.ts
+++ b/chrome/browser/resources/settings/router.ts
@@ -121,6 +121,7 @@ export interface SettingsRoutes {
IMPORT_DATA: Route;
SIGN_OUT: Route;
// </if>
+ GET_STARTED: Route; SHIELDS: Route; SOCIAL_BLOCKING: Route; EXTENSIONS: Route; EXTENSIONS_V2: Route; BRAVE_SYNC: Route; BRAVE_SYNC_SETUP: Route; BRAVE_WALLET: Route; BRAVE_WEB3: Route; BRAVE_NEW_TAB: Route; THEMES: Route;
+ GET_STARTED: Route; SHIELDS: Route; SOCIAL_BLOCKING: Route; EXTENSIONS: Route; EXTENSIONS_V2: Route; BRAVE_SYNC: Route; BRAVE_SYNC_SETUP: Route; BRAVE_WALLET: Route; BRAVE_WEB3: Route; BRAVE_NEW_TAB: Route; THEMES: Route; SITE_SETTINGS_AUTOPLAY: Route; SITE_SETTINGS_GOOGLE_SIGN_IN: Route; SITE_SETTINGS_LOCALHOST_ACCESS: Route; SITE_SETTINGS_BRAVE_OPEN_AI_CHAT: Route; SITE_SETTINGS_ETHEREUM: Route; SITE_SETTINGS_SOLANA: Route; SITE_SETTINGS_SHIELDS_STATUS: Route; SHIELDS_ADBLOCK: Route; SHORTCUTS: Route; BRAVE_WALLET_NETWORKS: Route; BRAVE_LEO_ASSISTANT: Route; BRAVE_CONTENT: Route;
}

/** Class for navigable routes. */
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.ts b/chrome/browser/resources/settings/site_settings_page/site_settings_page.ts
index dfb10f1a4817d61db2f0b2b21fc8e53d9ffe413b..2026d4eb98765151313c3dd2bc6ac6bfa6642d24 100644
index dfb10f1a4817d61db2f0b2b21fc8e53d9ffe413b..71b1cc5e31ec22c14821a7f62caf37a5785ceced 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.ts
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.ts
@@ -9,6 +9,7 @@
Expand All @@ -10,3 +10,19 @@ index dfb10f1a4817d61db2f0b2b21fc8e53d9ffe413b..2026d4eb98765151313c3dd2bc6ac6bf
import 'chrome://resources/cr_elements/cr_collapse/cr_collapse.js';
import 'chrome://resources/cr_elements/cr_expand_button/cr_expand_button.js';
import 'chrome://resources/cr_elements/cr_link_row/cr_link_row.js';
@@ -566,6 +567,7 @@ export class SettingsSiteSettingsPageElement extends
Id.AUTOMATIC_FULLSCREEN,
Id.OFFER_WRITING_HELP,
]),
+ shieldsBasic: buildItemListFromIds([]),
};
},
},
@@ -644,6 +646,7 @@ export class SettingsSiteSettingsPageElement extends
permissionsAdvanced: CategoryListItem[],
contentBasic: CategoryListItem[],
contentAdvanced: CategoryListItem[],
+ shieldsBasic: CategoryListItem[],
};

override currentRouteChanged() {

0 comments on commit 5272a71

Please sign in to comment.