Test split view bg color in custom theme from web store #27124
Conversation
fix brave/brave-browser#43057 This is regression from #27008 `nala::kColorDesktopbrowserTabbarActiveTabVertical` and `nala::kColorDesktopbrowserTabbarHoverTabVertical` didn't work for private/tor window. Fixed by setting different colors for above in private/tor theme.
| mixer[kColorBraveSplitViewTileBackgroundHorizontal] = { | ||
| is_toolbar_dark ? nala::kColorPrimitiveNeutral10 | ||
| : nala::kColorPrimitiveNeutral80}; | ||
| mixer[kColorBraveSplitViewTileBackgroundVertical] = { | ||
| kColorBraveSplitViewTileBackgroundHorizontal}; | ||
| mixer[kColorBraveSplitViewTileDivider] = { | ||
| is_toolbar_dark ? nala::kColorPrimitiveNeutral20 | ||
| : nala::kColorPrimitiveNeutral90}; |
There was a problem hiding this comment.
As these colors are our own color, custom theme doesn't have color for them.
@aguscruiz what I test here is picking similar color of toolbar between our light/dark theme colors for split view tile bg color.
You can see the some screenshots with downloaded custom theme from webstore.
Or, maybe we need to generate when custom theme is used?
There was a problem hiding this comment.
In these two screenshots the theme is dark but the color being used for active tabs and split tabs are the light ones. So, in those cases, the color theme the user chose independent of wether they have light/dark mode in the browser. Just tested it myself to confirm that.
Let me see how I can solve that split view bg being bad. We'll need a custom solution here, like you suggested
simonhong
force-pushed
the
fix_private_window_vertical_tab_color
branch
from
4834fd8 to
689e490
Compare
fix brave/brave-browser#43052
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: