fix(common): fix equality check for Chain objects with None #166
+78
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onyb
force-pushed
the
h/swap/fix-chain-equality
branch
from
45d3e42 to
059389e
Compare
onyb
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where comparing Chain enum objects with None would cause an error (GATE3-20 on Sentry). The fix adds proper type checking in the Chain.eq method to safely handle comparisons with None and other non-Chain objects.
Key changes:
- Updated Chain.eq to check if the other object is None or not a Chain instance before comparing attributes
- Added comprehensive test coverage for Chain equality edge cases
- Version bumped to 0.11.1
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version bump from 0.11.0 to 0.11.1 for the bug fix release |
| app/api/common/models.py | Fixed Chain.eq to handle None and non-Chain object comparisons safely |
| app/api/common/test_models.py | Added comprehensive tests for Chain equality including None, invalid types, and valid chain comparisons |
| app/api/swap/providers/jupiter/client.py | Code formatting improvement (split long line) |
| app/api/oauth/zebpay.py | Import reordering to follow PEP 8 conventions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| none = None | ||
| assert (none == chain) is False | ||
|
|
||
| assert chain == chain |
There was a problem hiding this comment.
Comparison of identical values; use cmath.isnan() if testing for not-a-number.
Suggested change
| assert chain == chain |
| assert (none == chain) is False | ||
|
|
||
| assert chain == chain | ||
| assert chain is chain |
There was a problem hiding this comment.
Comparison of identical values; use cmath.isnan() if testing for not-a-number.
Suggested change
| assert chain is chain | |
| assert isinstance(chain, Chain) |
|
Sentry Issue: GATE3-20 |
Douglashdaniel
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GATE3-20 on Sentry