fix for localhost redis fallback logic#394
Open
wfairclough wants to merge 1 commit intobrave:masterfrom
Open
Conversation
In Go `strings.Split("", ",")` returns `[]string{""}` of len == 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Redis fallback logic in
NewRedisClient. When REDIS_URLis empty, strings.Split("", ",")returns []string{""}(length 1), so the old len(addrs) == 0check never triggered the localhost fallback. This moves the empty check before the split so the fallback to localhost:6379works correctly.Also fixes a typo in Redis default port number (
6397-> 6379).