Skip to content

chore(lint): fixes#395

Draft
mschfh wants to merge 3 commits intomasterfrom
mschfh-lint-fixes
Draft

chore(lint): fixes#395
mschfh wants to merge 3 commits intomasterfrom
mschfh-lint-fixes

Conversation

@mschfh
Copy link
Contributor

@mschfh mschfh commented Feb 24, 2026

No description provided.

@mschfh mschfh requested a review from DJAndries February 24, 2026 19:17
@mschfh mschfh self-assigned this Feb 24, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies linting fixes to address gosec security warnings and formatting issues throughout the codebase.

Changes:

  • Added gosec nolint directives with explanatory comments for intentional security suppressions (pprof endpoints, error handling in shutdown)
  • Changed maxSize parameter type from int64 to int32 in GetUpdatesForType method across all interfaces, implementations, mocks, and call sites to match AWS DynamoDB SDK requirements
  • Applied multi-line formatting to function calls and definitions with many parameters for improved readability

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/server.go Added gosec nolint comments for pprof import, server shutdown, and pprof listener
datastore/sync_entity_test.go Reformatted GetUpdatesForType test calls to multi-line format
datastore/sync_entity.go Changed maxSize parameter from int64 to int32; reformatted long function calls
datastore/item_count_test.go Reformatted ClientItemCounts struct initialization
datastore/item_count.go Reformatted long expression and UpdateClientItemCount signature
datastore/instrumented_datastore.go Updated GetUpdatesForType signature to use int32 for maxSize
datastore/datastoretest/mock_datastore.go Updated mock method signatures to use int32; applied multi-line formatting
datastore/datastore.go Updated interface signatures for GetUpdatesForType and UpdateClientItemCount
command/server_defined_unique_entity.go Reformatted createServerDefinedUniqueEntity signature
command/command_test.go Reformatted NewPBSyncAttrs signature and long function calls
command/command.go Changed maxGUBatchSize to int32; added gosec nolint for safe conversion; reformatted signatures
cache/cache.go Reformatted IncrementInterimCount signature
auth/auth.go Added gosec nolint for false positive on regex pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants