Permitir comprar mas consumibles en vista de acceso a mentorships #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefer94
requested changes
Jan 9, 2024
| if plan_financing is not None: | ||
| user_plans = plan_financing.plans.all() | ||
|
|
||
| for plan in user_plans: |
There was a problem hiding this comment.
This for has not sense here
| return render_message(request, str(e), status=402) | ||
| from breathecode.payments.models import Subscription, PlanOffer, PlanFinancing | ||
|
|
||
| context = build_context() |
There was a problem hiding this comment.
These lines are unused
context = build_context()
context, args, kwargs = consumer(context, args, kwargs)|
|
||
| renovate_consumables = {} | ||
| url = request.path | ||
| match = re.search(r'service/(.*)', url) |
There was a problem hiding this comment.
This decorator is generic, you cannot use it just for mentorship purpose
There was a problem hiding this comment.
Maybe you should use something inside the consumer method to deal with it
jefer94
requested changes
Jan 15, 2024
| subscription = Subscription.objects.filter( | ||
| user=request.user, | ||
| plans__mentorship_service_set__mentorship_services__slug=service).first() | ||
|
|
There was a problem hiding this comment.
It only works with mentorship services and it should fail if the consumer has custom rules of comsuption, causing a message error related to consumables within a resource that was marked as free for users with that permission
jefer94
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breatheco-de/breatheco-de#6270