Skip to content

[frb] : Add support for Dart/Flutter bindings - Part I #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 29, 2024
Merged

[frb] : Add support for Dart/Flutter bindings - Part I #116

merged 16 commits into from
Apr 29, 2024

Conversation

erdemyerebasmaz
Copy link
Contributor

This PR creates the underlying work on Rust project to generate Dart bindings as part of

Changelist:

  • flutter_rust_bridge dependency is added as a feature named frb and won't be compiled by default.
  • Made necessary file changes required by flutter_rust_bridge
    • No code on lib.rs except use declarations, defining modules etc.
  • Created Rust input file, bindings.rs, to generate Dart bindings

@erdemyerebasmaz erdemyerebasmaz added this to the v0.1.0 milestone Apr 29, 2024
dangeross
dangeross reviewed Apr 29, 2024
View reviewed changes
dangeross
dangeross reviewed Apr 29, 2024
View reviewed changes
@erdemyerebasmaz
Copy link
Contributor Author

@ok300, several issues on ls-sdk-bindings appeared after rebasing on top of main, we can merge after they are fixed.

CC:@dangeross

@erdemyerebasmaz
Copy link
Contributor Author

@ok300, several issues on ls-sdk-bindings appeared after rebasing on top of main, we can merge after they are fixed.

CC:@dangeross

Fixed.

dangeross
dangeross reviewed Apr 29, 2024
View reviewed changes
@erdemyerebasmaz erdemyerebasmaz changed the base branch from main to ok300-rename-init-to-connect April 29, 2024 15:06
Base automatically changed from ok300-rename-init-to-connect to main April 29, 2024 15:25
ok300 and others added 14 commits April 29, 2024 18:40
@ok300 @erdemyerebasmaz
Update RN bindings
4d710cd
@dangeross @erdemyerebasmaz
Rename the manually coded init function to connect
8aef55e
@erdemyerebasmaz
Add flutter_rust_bridge crate and make necessary changes on file stru…
25d945d 
…cture

flutter_rust_bridge is added as a feature named "frb"
@erdemyerebasmaz
Create bindings for Dart/Flutter generation on Rust
f268182
@erdemyerebasmaz
Apply frb's file structure changes to cli
3b94544
@erdemyerebasmaz
Apply frb's file structure changes to ls-sdk-bindings
ba28e75
@erdemyerebasmaz
Enable frb feature by default
7e21180
@erdemyerebasmaz
Expose LBtcReverseRecovery through crate explicitly on Rust input fil…
b0f3578 
…e of Dart bindings

Otherwise it won't be resolved on the generated files.
@erdemyerebasmaz
Add backup & restore to Dart bindings
cb7ccf3
@erdemyerebasmaz
Move PaymentError to error.rs
63be609
@erdemyerebasmaz
Update Cargo.lock
811f99f
@erdemyerebasmaz
Ran cargo fmt & added empty file for generated Bindings
c54e61b
@erdemyerebasmaz
Revert "Apply frb's file structure changes to ls-sdk-bindings"
08aa2ea
@erdemyerebasmaz
Rename init() to connect()
0b07484
@erdemyerebasmaz erdemyerebasmaz merged commit 5100d63 into main Apr 29, 2024
@erdemyerebasmaz erdemyerebasmaz deleted the dart_bindings branch June 21, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangeross dangeross dangeross left review comments

@hydra-yse hydra-yse hydra-yse approved these changes

@ok300 ok300 ok300 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@erdemyerebasmaz @dangeross @hydra-yse @ok300