Skip to content

Commit

Permalink
update core lightning to v23.08
Browse files Browse the repository at this point in the history
  • Loading branch information
JssDWt committed Aug 28, 2023
1 parent 72c2b47 commit 2c39665
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/actions/setup-clightning/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ description: 'Set up Core Lightning on the runner'

inputs:
checkout-version:
description: 'v23.05.1'
description: Core lightning version
required: true
default: 'v23.05.1'
default: 'v23.08'

runs:
using: 'composite'
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/integration_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ on:
env:
BITCOIN_VERSION: '25.0'
LSP_REF: 'breez-node-v0.16.4-beta'
CLIENT_REF: 'v0.16.4-breez-2'
CLIENT_REF: 'v0.16.4-breez-3'
GO_VERSION: '^1.19'
CLN_VERSION: 'v23.05.1'
CLN_VERSION: 'v23.08'
jobs:

setup-bitcoin-core:
Expand All @@ -18,7 +18,6 @@ jobs:
uses: actions/checkout@v3

- name: Set up Bitcoin Core
if: steps.cache-bitcoin.outputs.cache-hit != 'true'
uses: ./.github/actions/setup-bitcoin
with:
bitcoin-version: ${{ env.BITCOIN_VERSION }}
Expand All @@ -30,7 +29,6 @@ jobs:
uses: actions/checkout@v3

- name: Set up LND LSP
if: steps.cache-lnd-lsp.outputs.cache-hit != 'true'
uses: ./.github/actions/setup-lnd-lsp
with:
lsp-ref: ${{ env.LSP_REF }}
Expand All @@ -43,7 +41,6 @@ jobs:
uses: actions/checkout@v3

- name: Set up LND client
if: steps.cache-lnd-client.outputs.cache-hit != 'true'
uses: ./.github/actions/setup-lnd-client
with:
client-ref: ${{ env.CLIENT_REF }}
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export LISTEN_ADDRESS=<listen address>
- `--plugin=/path/to/shell/script.sh`: to use lspd as plugin
- `--max-concurrent-htlcs=30`: In order to use zero reserve channels on the client side, (local max_accepted_htlcs + remote max_accepted_htlcs + 2) * dust limit must be lower than the channel capacity. Reduce max-concurrent-htlcs or increase channel capacity accordingly.
- `--dev-allowdustreserve=true`: In order to allow zero reserve on the client side, you'll need to enable developer mode on cln (`./configure --enable-developer`)
- `--experimental-anchors`: In order to allow opening anchor channels.
1. Run lspd

### Final step
Expand All @@ -56,7 +57,7 @@ The lsp supports probing non-mpp payments if the payment hash for probing is sha
In order to run the integration tests, you need:
- Docker running
- python3 installed
- A development build of lightningd v23.05.1
- A development build of lightningd v23.08
- lnd v0.16.4 lsp version https://github.com/breez/lnd/commit/cebcdf1b17fdedf7d69207d98c31cf8c3b257531
- lnd v0.16.4 breez client version https://github.com/breez/lnd/commit/3c0854adcfc924a6d759a6ee4640c41266b9f8b4
- bitcoind (tested with v23.0)
Expand Down
1 change: 1 addition & 0 deletions itest/cln_breez_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ func newClnBreezClient(h *lntest.TestHarness, m *lntest.Miner, name string) Bree
// reserve channel. Relevant code:
// https://github.com/ElementsProject/lightning/blob/774d16a72e125e4ae4e312b9e3307261983bec0e/openingd/openingd.c#L481-L520
"--max-concurrent-htlcs=30",
"--experimental-anchors",
)

return &clnBreezClient{
Expand Down
1 change: 1 addition & 0 deletions itest/cln_lspd_node.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ func NewClnLspdNode(h *lntest.TestHarness, m *lntest.Miner, mem *mempoolApi, nam
"--max-concurrent-htlcs=30",
"--dev-allowdustreserve=true",
"--allow-deprecated-apis=true",
"--experimental-anchors",
}
lightningNode := lntest.NewClnNode(h, m, name, args...)
cln := &config.ClnConfig{
Expand Down

0 comments on commit 2c39665

Please sign in to comment.