lsps2: cleanup expired promises #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
force-pushed
the
lsps2-forward
branch
from
a24f5ff
to
a58c990
Compare
JssDWt
force-pushed
the
lsps2-promise-expiry
branch
from
b480275
to
084a4d8
Compare
roeierez
reviewed
Oct 23, 2023
| token varchar NOT NULL | ||
| ) | ||
| token varchar NOT NULL, | ||
| valid_until varchar NOT NULL |
There was a problem hiding this comment.
Doesn't adding a not null column require default value?
There was a problem hiding this comment.
There was a problem hiding this comment.
Since this table isn't merged into main yet, I feel free to add NOT NULL columns
|
This PR was pointing to the wrong branch, but it was merged here: 084a4d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121