Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LND lsp CLN client compatibility #134

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Conversation

JssDWt
Copy link
Collaborator

@JssDWt JssDWt commented Oct 17, 2023

This PR adds compatibility between the LND lsp and an sdk client.

A config parameter is added: legacyOnionTokens. If you're running an LND lsp, and you are serving breezmobile clients, every token used to connect to the LSP from these types of clients must be put in the legacyOnionTokens array. If the token is not in that array, but you are routing to a breezmobile client, the client will not accept the htlc.

In that sense, this is a breaking change, because without the tokens in that config option, you will not be able to route to breezmobile clients anymore.

Requires an update to LND to be able to serve sdk clients: breez/lnd#9

@JssDWt JssDWt force-pushed the lnd-forward-original-onion-v2 branch 4 times, most recently from 9f66f5b to 8635de4 Compare October 17, 2023 16:04
@JssDWt JssDWt marked this pull request as ready for review October 17, 2023 17:20
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JssDWt JssDWt force-pushed the lnd-forward-original-onion-v2 branch 10 times, most recently from fc5aad7 to 47ad38f Compare October 17, 2023 23:08
@JssDWt JssDWt force-pushed the lnd-forward-original-onion-v2 branch from 47ad38f to c25a6e1 Compare October 17, 2023 23:45
@JssDWt JssDWt merged commit c25a6e1 into master Oct 18, 2023
48 of 49 checks passed
@JssDWt JssDWt deleted the lnd-forward-original-onion-v2 branch November 16, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants