Open
Conversation
JssDWt
force-pushed
the
failure-messages
branch
2 times, most recently
from
cb7e8f1 to
43b2c52
Compare
JssDWt
force-pushed
the
failure-messages
branch
from
43b2c52 to
9e523f9
Compare
yaslama
approved these changes
Jan 26, 2024
Member
yaslama
left a comment
yaslama
left a comment
There was a problem hiding this comment.
LGTM, but I don't know if it's a good idea to use it in prod before lightningnetwork/lnd#7067 is merged
Collaborator
Author
|
Put on hold until lightningnetwork/lnd#7067 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of failure codes, we use failure messages. This gives lspd more control over the returned failure to the sender. In the case of a temporary channel failure for example, we are able to return the correct channel policy in the failure message, so the sender may be able to retry. This also allows us to return any error code, and aligns the interfaces for cln and lnd.
** !! **
Requires an update to LND, to include this PR lightningnetwork/lnd#7067
It is included in lnd here https://github.com/breez/lnd/tree/unencrypted-failure-messages