Forwarding history - no matching #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
force-pushed
the
forwarding-history-v3
branch
2 times, most recently
from
c8d631c
to
3704782
Compare
yaslama
approved these changes
Feb 8, 2024
JssDWt
force-pushed
the
forwarding-history-v3
branch
from
3704782
to
99f6a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronizes forwarding history and channels with the node. In intervals of 5 minutes.
For review, I think it's easiest to follow the commits, rather than going over the code at once.
The existing forwarding history sync was made with the idea that a single node would be running lspd and it only worked for LND. Since lspd can be run with multiple lightning nodes, the synchronization of forwards now works for both cln and lnd, and the node id is persisted with the forward.
The existing
forwarding_historyandchannelstables are renamed with a _backup suffix. Since some information about channels from LND is no longer available on the node, it could be useful to keep this information. The synchronization will start again from the start of the node's lifetime the first time you run lspd.InitialChannelId is renamed to AliasScid, because this better reflects what the field means.
Replaces #150 , but without matching forwards from different lightning nodes.