Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Webhook Subcription URL #194

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Remove Webhook Subcription URL #194

merged 2 commits into from
Feb 29, 2024

Conversation

hydra-yse
Copy link
Contributor

@hydra-yse hydra-yse commented Feb 25, 2024

Closes breez/breez-sdk-greenlight#730

This PR aims at giving the user the possibility to unsubscribe to a given notification by providing its associated webhook's URL.

@hydra-yse hydra-yse self-assigned this Feb 25, 2024
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Maybe we can add a tiny integration test for the subscribe/unsubscribe by only running lspd and checking the postgres database in the test?

notifications/server.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hydra-yse hydra-yse merged commit 11f35cb into master Feb 29, 2024
59 checks passed
@JssDWt JssDWt deleted the yse-webhook-unsubscribe branch May 24, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot remove a registered webhook URL
3 participants