Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cln: replace glightning socket api with grpc api #215

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

JssDWt
Copy link
Collaborator

@JssDWt JssDWt commented Apr 8, 2024

In this PR the client used to connect to cln is replaced with grpc.
Previously we would connect to the cln api through glightning, using the lightning-rpc socket file.
Replacing with grpc has several advantages:

  • Breaking changes in the core lightning api will be reflected in the protos -> We have the advantage of code generation for client calls.
  • Adding calls to cln is easier, because we don't have to modify glightning to add functions or fields
  • This setup is better suited for container deployments

This is a breaking change!

The glightning socket api was removed and replaced with the grpc one.

LSPD's NODES configuration has changed to contain grpc addresses and certficates. Note the certficates can be either a file path or a raw certificate.

@JssDWt JssDWt requested review from yaslama and hydra-yse April 8, 2024 12:21
Copy link
Contributor

@hydra-yse hydra-yse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JssDWt JssDWt merged commit 28a5c8f into master Apr 18, 2024
7 checks passed
@JssDWt JssDWt deleted the jssdwt-grpc branch May 24, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants