Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line number from stackcollapse-wcp output #331

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iTrooz
Copy link

@iTrooz iTrooz commented Feb 19, 2024

Right now stackcollapse-wcp.pl keeps the file and line numbers as part of the function name (so a function is named main (at main.cpp:50 for example)

This causes functions to be registered multiple times (see screenshots)

I'm not 100% sure, but I'd say that this is not how flame graphs work, and not a wanted behavior ?

Without patch:
without_patch

With patch
with_patch

@iTrooz
Copy link
Author

iTrooz commented Feb 21, 2024

Actually, I noticed that line numbers can sometimes be useful to know what function a frame actually corresponds to (for example, Vec#contains() in Rust is not shown well), or when a given functions calls another functions several times (e.g. multiple push() made in the same function) so I added a --lines options (off by default) to separate by line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant