Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the model, regenerate, and related changes #167

Merged

Conversation

madjar
Copy link
Contributor

@madjar madjar commented Jul 28, 2021

Hey @brendanhay!

Sorry to have more PRs just after you finished merging the previous ones :) (but this one the logical consequence of the previous ones: allowing a regen on the brand new model!)

  • The first commit add Nothing as a reserved word because it's now used by an API
  • The second one is a massive update of the model, and the regen that goes along with it.
  • The third commit a tiny fix to the examples, to work with the update model

Sadly, I wasn't able to make stylish-haskell work on my laptop (or rather, I killed it when it reached 40G of memory trying to format the 2.5M-big gogol-compute/gen/Network/Google/Compute/Types/Product.hs), so some of the diff is changes in formatting.

I did check that everything generates, and everything compiles, so this should allow usage of all the new changes in the APIs! (and it supersedes #149).

Have a nice day!

@brendanhay
Copy link
Owner

Awesome! 💪🏽

There's some changes afoot to bring gogol inline with amazonka's use of haskell.nix and ormolu - so hopefully we can get rid of stylish-haskell/hindent soon.

@brendanhay brendanhay merged commit 2d3d931 into brendanhay:develop Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants