forked from dependabot/dependabot-core
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixup
pip_version_resolver
specs (dependabot#7699)
While working on the PR to drop support for Python 3.6, I noticed these specs could use some tidying up: 1. `3.7` will soon be dropped, so bumped the "latest" version to `3.11`. 2. We had no explicit test of what happens when an outdated Python version was specified. Finally, the biggest change is removing the test of "old python version supported by Dependabot but not supported by a newer version of the library". The problem is that while nice to have the scenario it's testing is becoming less realistic. Overall (and I say this as someone who helps maintain several popular Python open source libraries) the Python ecosystem has been aligning pretty closely to the upstream version support lifecycle. Ie, library maintainers are starting to align when they drop support for old python versions with the upstream EOL cycle. Similarly, we're moving towards here in Dependabot. So it's going to be really hard to find an example of a library that releases a new version dropping support for a Python version that isn't EOL'd... or if it is EOL'd, then most likely we've dropped support for that Python version here in Dependabot. And even if I do manage to track down a library doing this, or mock a fake response from PyPI, it'll be a brittle test because every year we'll be dropping support for that old version. So instead I think the test of "that is set to a python version no longer supported by Dependabot" is a more realistic test scenario. I also tidied up some similar examples of this test to be consistent in formatting... their contents didn't change.
- Loading branch information
1 parent
a2a8900
commit 3e39085
Showing
3 changed files
with
35 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters