Skip to content

Commit

Permalink
Update poetry test of oldest supported python version to 3.8 (depen…
Browse files Browse the repository at this point in the history
…dabot#7691)

This test ensures that the installed version of `poetry` works as
expected with the oldest version of python currently supported by
Dependabot. It (hopefully) prevents us from installing newer poetry
versions that don't have support for older python versions.

In just a couple of weeks we will be deprecating Python 3.6/3.7... So
3.8 will become the oldest version of Python supported by Dependabot.

So update the test accordingly.

To update I ran the following commands:
```shell
bin/docker-dev-shell python
pyenv install 3.8.17  # matches the version available to be installed from the `python/Dockerfile`
PYENV_VERSION=3.8.17 pyenv exec pip install --upgrade pip
PYENV_VERSION=3.8.17 pyenv exec pip install poetry
PYENV_VERSION=3.8.17 pyenv exec poetry lock --no-update
```
  • Loading branch information
jeffwidman authored Aug 1, 2023
1 parent 1b36b4b commit 659e36e
Show file tree
Hide file tree
Showing 4 changed files with 352 additions and 354 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@
end
end

context "with a supported python version", :slow do
let(:python_version) { "3.6.9" }
let(:pyproject_fixture_name) { "python_36.toml" }
let(:lockfile_fixture_name) { "python_36.lock" }
context "with the oldest python version currently supported by Dependabot", :slow do
let(:python_version) { "3.8.17" }
let(:pyproject_fixture_name) { "python_38.toml" }
let(:lockfile_fixture_name) { "python_38.lock" }
let(:dependency) do
Dependabot::Dependency.new(
name: "django",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description = ""
authors = ["Your Name <you@example.com>"]

[tool.poetry.dependencies]
python = "3.6.9"
python = "3.8.17"
requests = "^2.27.1"
Django = "3.0"

Expand Down
349 changes: 0 additions & 349 deletions python/spec/fixtures/pyproject_locks/python_36.lock

This file was deleted.

Loading

0 comments on commit 659e36e

Please sign in to comment.