Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to use SSL certifications generated from specific host (Create certificaitons in CI) #1310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junaruga
Copy link
Contributor

@junaruga junaruga commented Feb 16, 2023

This PR is alternative for the #1296 with less modification. What do you think? Is this PR better for you than the #1296?


In the Fedora project, we are running the mysql2 tests on the build environment with a user permission, without root permission and without sudo.

In this case, we couldn't set up the custom domain "mysql2gem.example.com" to run SSL tests. The feature to create a set of the SSL certifications from the localhost gives an option to run the SSL tests executed in the environment.

How to generate the certificaton files:

$ cd spec/ssl/
$ TEST_RUBY_MYSQL2_SSL_CERT_HOST=localhost bash gen_certs.sh

The files are generated in the spec/ssl directory.

How to use:

$ TEST_RUBY_MYSQL2_SSL_CERT_HOST=localhost \
bundle exec rake spec

In the Fedora project, we are running the mysql2 tests on the build environment
with a user permission, without root permission and without `sudo`.

In this case, we couldn't set up the custom domain "mysql2gem.example.com"
to run SSL tests. The feature to create a set of the SSL certifications
from the localhost gives an option to run the SSL tests executed in the environment.

How to generate the certificaton files:

```
$ cd spec/ssl/
$ TEST_RUBY_MYSQL2_SSL_CERT_HOST=localhost bash gen_certs.sh
```

The files are generated in the `spec/ssl` directory.

How to use:

```
$ TEST_RUBY_MYSQL2_SSL_CERT_HOST=localhost \
bundle exec rake spec
```
@junaruga junaruga changed the title Add an option to use SSL certifications generated from specific host (Create certificaitons in the process of CI) Add an option to use SSL certifications generated from specific host (Create certificaitons in CI) Feb 16, 2023
@junaruga
Copy link
Contributor Author

For the CI failures on mariadb 10.11 in Ubuntu 22.04, I opened the ticket #1311 to manage the issue.

@sodabrew
Copy link
Collaborator

Thanks! I hadn't forgotten about the other PR, just didn't have time to review PRs again this month. Thanks for proposing a smaller scope, I think that will make it easier to digest.

@junaruga
Copy link
Contributor Author

All right. Thanks for sharing your situation!

@junaruga
Copy link
Contributor Author

Hi, just a friendly reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants