Add bigdecimal to runtime dependencies #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.4 will promote bigdecimal gem to a bundled gem in order to improve maintenancebility. To migrate to Ruby 3.4 easily, Ruby 3.3 warns a use of bigdecimal without adding it to dependencies. > /build/lib/mysql2.rb:2: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. So this patch adds bigdecimal to runtime dependencies. I know bigdecimal is not always necessary, but I'd like to prevent a lot of users from adding the gem to their Gemfile manually. Ref. https://bugs.ruby-lang.org/issues/20187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.4 will promote bigdecimal gem to a bundled gem in order to improve maintenancebility. To migrate to Ruby 3.4 easily, Ruby 3.3 warns a use of bigdecimal if it's not added to dependencies.
https://github.com/brianmario/mysql2/actions/runs/8972155446/job/24639503831#step:4:238
So this patch adds bigdecimal to runtime dependencies.
I know bigdecimal is not always necessary, but I'd like to prevent a lot of users from adding the gem to their Gemfile manually.
Ref. https://bugs.ruby-lang.org/issues/20187
Slides from RubyKaigi 2024: https://speakerdeck.com/andpad/long-journey-of-ruby-standard-library-rubykaigi-2024