Use cfg!(target_feature) for static ARM/AARCH64 feature detection.
#1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/aarch64-feature-2
branch
from
44463ff
to
74d36b9
Compare
briansmith
changed the title
cfg!(target_feature) for static AARCH64 feature detection.cfg!(target_feature) for static ARM/AARCH64 feature detection.
Codecov Report
@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
- Coverage 96.02% 96.01% -0.01%
==========================================
Files 133 133
Lines 19913 19913
Branches 199 199
==========================================
- Hits 19121 19120 -1
Misses 754 754
- Partials 38 39 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
briansmith
force-pushed
the
b/aarch64-feature-2
branch
from
74d36b9
to
2a383a3
Compare
briansmith
force-pushed
the
b/aarch64-feature-2
branch
2 times, most recently
from
d1245ff
to
e7c214a
Compare
briansmith
force-pushed
the
b/aarch64-feature-2
branch
2 times, most recently
from
b2d2d58
to
a74a1be
Compare
briansmith
commented
Sep 30, 2023
| ); | ||
| // MSRV: Enforce 1.61.0 on some aarch64-* targets (aarch64-apple-*, in particular) prior to. Earlier | ||
| // versions of Rust before did not report the AAarch64 CPU features correctly for these targets. | ||
| // Cargo.toml specifies `rust-version` but versions before Rust 1.56 don't know about it. |
There was a problem hiding this comment.
I verified that cargo test +1.60.0 --target=aarch64-apple-darwin fails due to this, and cargo test +1.61.0 --target=aarch64-apple-darwin passes.
briansmith
force-pushed
the
b/aarch64-feature-2
branch
from
a74a1be
to
11cdbda
Compare
briansmith
force-pushed
the
b/aarch64-feature-2
branch
from
11cdbda
to
df29dd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our MSRV supports
ifin const expressions. Implement a workaround for buggy detection on older versions of Rust.