Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add riscv64gc-unknown-linux-gnu support to mk/. #1562

Closed
wants to merge 1 commit into from

Conversation

briansmith
Copy link
Owner

No description provided.

@briansmith briansmith self-assigned this Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1562 (80544a3) into main (450ada2) will increase coverage by 2.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
+ Coverage   90.09%   92.26%   +2.16%     
==========================================
  Files         121      127       +6     
  Lines       14259    18811    +4552     
  Branches      166      196      +30     
==========================================
+ Hits        12847    17356    +4509     
- Misses       1380     1420      +40     
- Partials       32       35       +3     
Impacted Files Coverage Δ
src/aead/shift.rs 40.00% <0.00%> (-60.00%) ⬇️
src/aead/aes.rs 81.25% <0.00%> (-2.01%) ⬇️
src/aead/gcm/gcm_nohw.rs 0.00% <0.00%> (ø)
crypto/curve25519/internal.h 100.00% <0.00%> (ø)
crypto/fipsmodule/bn/internal.h 100.00% <0.00%> (ø)
crypto/fipsmodule/aes/aes_nohw.c 0.00% <0.00%> (ø)
crypto/poly1305/poly1305.c 96.74% <0.00%> (ø)
third_party/fiat/p256_32.h 100.00% <0.00%> (ø)
crypto/fipsmodule/ec/p256.c 99.60% <0.00%> (ø)
crypto/fipsmodule/ec/gfp_p256.c 100.00% <0.00%> (ø)
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@light4 light4 mentioned this pull request Jan 10, 2023
@MichaIng
Copy link

MichaIng commented Mar 5, 2023

We are highly interested in this. Let me know if we can help, e.g. with testing on a physical riscv64 system.

@MichaIng
Copy link

MichaIng commented Mar 27, 2023

I'm currently trying to compile vaultwarden on riscv64.

I can verify that ring compiles successfully on riscv64 with this minimal (compared to other open PRs) change in include/ring-core/base.h (excluding the CI part). But since the API changed in 0.17.0 so far (right?), other crates fail to work with it.

On 0.16.20, more changes are needed, which I'm currently trying to identify. Let me know whether there is some interest in a compatible 0.16.21 release with riscv64 support that has been tested with vaultwarden, if I'm able to succeed.

@briansmith
Copy link
Owner Author

This was done in PR #1627.

@briansmith briansmith closed this Sep 30, 2023
@briansmith briansmith deleted the b/mipsel-riscv64gc branch September 30, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants