-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Move from winapi
to windows-sys
#1595
deps: Move from winapi
to windows-sys
#1595
Conversation
@poliorcetics Fair enough. What's the MSRV policy for windows-sys? |
Current MSRV seems to be 1.48. This is the closest to a "policy" I find: microsoft/windows-rs#2300 |
EDIT: negative is hard |
I can't get the GitHub Actions to let me run this in CI. Could you please rebase this on top of the latest |
`winapi` is in maintenance mode and the new blessed way to access Windows APIs are the `windows` and `windows-sys` crates. I don't think any types of `winapi` were exposed in the public API so I used `windows-sys` since it has much faster compile times.
d04ed85
to
f493f89
Compare
Codecov Report
@@ Coverage Diff @@
## main #1595 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 132 132
Lines 18845 18845
Branches 196 196
=======================================
+ Hits 17383 17384 +1
Misses 1426 1426
+ Partials 36 35 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Also of note: in the past the Windows-rs team has reduced the MSRV if it proved important for a crate and it was feasible: GuillaumeGomez/sysinfo#950 (comment) :) |
Thanks! |
winapi
is in maintenance mode and the new blessed way to access Windows APIs are thewindows
and
windows-sys
crates. I don't think any types ofwinapi
were exposed in the public API soI used
windows-sys
since it has much faster compile times.