Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: CPU: Clarify safety invariants around OPENSSL_armcap_P. #1673

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

briansmith
Copy link
Owner

No description provided.

@briansmith
Copy link
Owner Author

@joshlf PTAL.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #1673 (2994555) into main (901441f) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1673      +/-   ##
==========================================
- Coverage   96.04%   96.03%   -0.01%     
==========================================
  Files         133      133              
  Lines       19913    19921       +8     
  Branches      199      199              
==========================================
+ Hits        19125    19131       +6     
  Misses        752      752              
- Partials       36       38       +2     
Files Coverage Δ
src/cpu.rs 100.00% <100.00%> (ø)
src/cpu/arm.rs 95.00% <100.00%> (+0.43%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@briansmith
Copy link
Owner Author

Once we're done with this, I will do the same for the Intel side.

@briansmith briansmith force-pushed the b/arm-setup-unsafe branch 2 times, most recently from d453c51 to 724091f Compare October 1, 2023 03:37
@briansmith briansmith merged commit 7b1937d into main Oct 1, 2023
160 of 161 checks passed
@briansmith briansmith deleted the b/arm-setup-unsafe branch October 1, 2023 21:25
@briansmith
Copy link
Owner Author

Another change I need to make depends on this, so I'm going to merge it as-is. If you comment on any of the SAFETY comment stuff, I'll update them in a future PR based on your comments.

@joshlf
Copy link
Contributor

joshlf commented Oct 10, 2023

@joshlf PTAL.

I don't know enough about OPENSSL_armcap_P to be able to give very precise feedback, but in broad strokes this looks like exactly the kind of reasoning that we try to encode in zerocopy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants