aes_gcm: Prefer integrated implementations, avoid inlining fallbacks. #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 151 151
Lines 20101 20101
Branches 447 447
=======================================
Hits 19524 19524
Misses 482 482
Partials 95 95 ☔ View full report in Codecov by Sentry. |
The `#[inline(always)]` on `open_strided` was just a mistake. But, even correcting that, the compiler won't structure `open()` and `seal()` in the expected way. With these changes, the integrated implementations will get inlined (as far as possible) and the compiler will be biased towards assuming they will be used.
briansmith
force-pushed
the
b/open-always
branch
from
6e398d9
to
838e0e3
Compare
briansmith
changed the title
briansmith
force-pushed
the
b/open-always
branch
from
5d4ca77
to
1cad1ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#[inline(always)]onopen_stridedwas just a mistake.But, even correcting that, the compiler won't structure
open()andseal()in the expected way. With these changes, the integrated implementations will get inlined (as far as possible) and the compiler will be biased towards assuming they will be used.