aes: Clarify counter overflow checking. #2120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2120 +/- ##
==========================================
- Coverage 97.12% 97.04% -0.09%
==========================================
Files 151 152 +1
Lines 20101 20475 +374
Branches 447 454 +7
==========================================
+ Hits 19524 19870 +346
- Misses 482 508 +26
- Partials 95 97 +2 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/ctr-checking
branch
2 times, most recently
from
4a24c88
to
dfb4f00
Compare
Move all the counter management to a submodule that can, in the future, be encapsulated from the rest of the AES and AES-GCM logic. `git difftool HEAD^1:src/aead/aes.rs src/aead/aes/counter.rs`
briansmith
force-pushed
the
b/ctr-checking
branch
4 times, most recently
from
686acdd
to
5c56776
Compare
Move `Conuter` and `Iv` to aes/counter.rs. Create a more robust internal API for counter/nonce/IV management that makes the usage within AES-GCM more clearly correct. The new design is easier to test. `git difftool HEAD^1:src/aead/aes.rs src/aead/aes/counter.rs`
briansmith
force-pushed
the
b/ctr-checking
branch
from
5c56776
to
812ebfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a more robust internal API for counter/nonce/IV management that makes the usage within AES-GCM more clearly correct. The new design is easier to test.