Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated connectable.ts to 1.20.60 and added stuff #144

Merged
merged 3 commits into from
May 17, 2024

Conversation

Miniontoby
Copy link
Contributor

Updated connectable.ts to 1.20.60 and added stuff

Stuff added/changed/fixed:

  • Added direction_combinations for making OR's possible between multiple collections of AND directions
  • Added UP and DOWN variants of the North, East, South, West directions.
  • Made the schema better with require statements
  • Fixed the typescript issues

Miniontoby added 2 commits May 6, 2024 19:16
Updated connectable.ts to 1.20.60 and added stuff

Stuff added:
- `direction_combinations` for making OR's possible between multiple collections of AND directions
- UP and DOWN variants of the North, East, South, West directions.
- Made the schema better with require statements
- Fixed the typescript issues
Copy link

stackblitz bot commented May 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Miniontoby
Copy link
Contributor Author

Miniontoby commented May 6, 2024

I have made sure it works, since I am working on a block that requires connections.

Here is the prove that it works.

image

P.s. yes, I did include the taskbar of Windows, just so you can see that it works today.

@outercloudstudio
Copy link
Member

Make sure to request a review from me once it's ready 👍

@Miniontoby
Copy link
Contributor Author

Make sure to request a review from me once it's ready 👍

I cannot find the button to request a review from you, but it is ready to be reviewed, tho

@outercloudstudio
Copy link
Member

outercloudstudio commented May 8, 2024

Make sure to request a review from me once it's ready 👍

I cannot find the button to request a review from you, but it is ready to be reviewed, tho

Ah might be a permissions thing. I'll review it asap.

@outercloudstudio outercloudstudio self-requested a review May 10, 2024 02:59
Copy link
Member

@outercloudstudio outercloudstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@outercloudstudio outercloudstudio merged commit bd00cb3 into bridge-core:master May 17, 2024
1 check passed
@Miniontoby Miniontoby deleted the patch-1 branch May 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants