Issue 291 #292
Draft
Issue 291 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tngTUDOR
commented
Dec 19, 2024
tngTUDOR
commented
- Add test for the condense multiline for ecospold2
- fixing # 291 for the generalComment
- must verify if ecospold1 has similar cases
- Other tags besides generalComment might have similar issues
Some ecospold2 tags may include "comments" that span over multiple "text" tags. There is nothing forbidding the "text" tags to be empty, and certain well known ecospold2 based databases have this clear cases. - add fixtures with empty text tags in generalComment for the activity tag Signed-off-by: tngTUDOR@users.noreply.github.com
related to brightway-lca#291 Signed-off-by: tngTUDOR@users.noreply.github.com
- Update the test expected outcome for brightway-lca#291 Signed-off-by: tngTUDOR@users.noreply.github.com
- Require the list of strings in the text tags of the comments to be not none before the join op Signed-off-by: tngTUDOR@users.noreply.github.com
- part of a fix for brightway-lca#291 Signed-off-by: tngTUDOR@users.noreply.github.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.