Skip to content

Upgrade Documentation (use Conda env. file, use Markdown instead of reStructuredText) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

michaelweinold
Copy link
Contributor

No description provided.

# sphinx
- sphinx=7.3.7 # core builder # https://anaconda.org/conda-forge/sphinx/files
# theme and extensions
- pydata-sphinx-theme=0.15.3 # website theme # https://anaconda.org/conda-forge/pydata-sphinx-theme/files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakobsarthur, these are the pinned versions I was referring to. You can always bump the package versions when either:

  1. You have tested the build with the new versions locally
  2. the docs.brightway.dev repo has bumped them

@@ -0,0 +1,189 @@
# Theory
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown is highly preferred! Otherwise, you won't be able to take advantage of all the MyST parser functionality.

@@ -1,12 +1,7 @@
### path setup ####################################################################################

from glob import glob
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that my local build works fine without these below definitions. Please let me know if this broke some other part of the documentation I am unaware of.

include: all

build:
os: "ubuntu-lts-latest" # https://docs.readthedocs.io/en/stable/config-file/v2.html#build-os
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new feature, but will ensure that the build always uses the most up-to-date platforms provided by RTD.

- sphinx-favicon=1.0.1 # for custom favicons # https://anaconda.org/conda-forge/sphinx-favicon/files
- sphinx-copybutton=0.5.2 # for copy button in code blocks # https://anaconda.org/conda-forge/sphinx-copybutton/files
# build process
- sphinx-autobuild=2024.4.16 # live-html support # https://anaconda.org/conda-forge/sphinx-autobuild/files
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...please check if you need any other packages.

@jakobsarthur jakobsarthur requested review from TimoDiepers and removed request for TimoDiepers June 26, 2024 06:51
@jakobsarthur
Copy link
Collaborator

I built it locally and it seems to all be working! will goahead and merge

@jakobsarthur jakobsarthur merged commit 0bafebc into main Jun 26, 2024
3 checks passed
@jakobsarthur jakobsarthur deleted the documentation_upgrade branch June 26, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants