Include dynamic inventory directly from timeline and performance improvement #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 26, 2024 09:12
…ass id to biosphere_time_mapping_dict instead of node
TimoDiepers
reviewed
Jul 10, 2024
There was a problem hiding this comment.
@jakobsarthur there is some of your profiling stuff in here still - maybe delete those or just roll this back to the previous version
…mic_biobuilder_from_timeline
|
Good point! I will clean up the notebook before the next push. Another push coming tonight with the cleaned up timex_lca.lci
From: Timo Diepers ***@***.***>
Date: Wednesday, 10 July 2024 at 15:19
To: brightway-lca/bw_timex ***@***.***>
Cc: Jakobs Artos ***@***.***>, Mention ***@***.***>
Subject: Re: [brightway-lca/bw_timex] Include dynamic inventory directly from timeline and performance improvement (PR #65)
@TimoDiepers commented on this pull request.
…________________________________
On notebooks/example_setac_patchwork.ipynb<#65 (comment)>:
@jakobsarthur<https://github.com/jakobsarthur> there is some of your profiling stuff in here still - maybe delete those or just roll this back to the previous version
—
Reply to this email directly, view it on GitHub<#65 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJKLX43XH3JX3LASMBN7YTZLUYGZAVCNFSM6AAAAABKS46OAOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRZGA3TGOBZGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
… default True. If False, it calculates the dynamic inventory directly from the timeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now calculate the dynamic inventory from the timeline and big performance improvement in lci() and lci_from_timeline() methods. 1m16s to ~10s