Bump eslint from 8.57.1 to 9.12.0

eslint.config.mjs

@@ -0,0 +1,82 @@
+import globals from 'globals';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import js from '@eslint/js';
+import { FlatCompat } from '@eslint/eslintrc';
+
+// eslint-disable-next-line no-underscore-dangle
+const __filename = fileURLToPath(import.meta.url);
+// eslint-disable-next-line no-underscore-dangle
+const __dirname = path.dirname(__filename);
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+export default [
+  {
+    ignores: [
+      'bin/**/*',
+      'build/**/*',
+      'coverage/**/*',
+      'docs/**/*',
+      'jsdoc/**/*',
+      'templates/**/*',
+      'tests/bench/**/*',
+      'tests/fixtures/**/*',
+      'tests/performance/**/*',
+      'tmp/**/*',
+      'public/**/*',
+      'node_modules/**/*',
+      'lib-cov/**/*',
+      '.grunt/**/*',
+      '.sonar/**/*',
+      'logs/**/*',
+      '.idea/**/*',
+      'samples/**/*',
+    ],
+  },
+  ...compat.extends('eslint-config-prettier'),
+  {
+    languageOptions: {
+      globals: {
+        ...globals.node,
+        ...globals.mocha,
+        ...globals.mongo,
+      },
+    },
+
+    rules: {
+      'no-await-in-loop': 0,
+      'comma-dangle': 0,
+      'max-classes-per-file': 0,
+
+      'max-len': [
+        'error',
+        {
+          code: 190,
+          ignoreComments: true,
+          ignoreUrls: true,
+        },
+      ],
+
+      'no-underscore-dangle': [
+        1,
+        {
+          allow: ['_config', '_connection', '_maxListeners'],
+          allowAfterThis: true,
+        },
+      ],
+
+      'no-return-await': 'off',
+      'no-console': 'error',
+      'no-param-reassign': 'error',
+      'global-require': 'error',
+      'no-unused-expressions': 'error',
+      'no-sequences': 'error',
+      'prefer-rest-params': 'error',
+      'func-names': ['error', 'as-needed'],
+    },
+  },
+];

package.json

@@ -40,12 +40,13 @@
     "serialize-error": "^8.0.1"
   },
   "devDependencies": {
+    "@eslint/js": "^9.13.0",
     "child-process-promise": "^2.2.1",
     "dot-only-hunter": "^1.0.3",
-    "eslint": "^8.25.0",
-    "eslint-config-airbnb-base": "^15.0.0",
-    "eslint-config-prettier": "^9.0.0",
-    "eslint-plugin-import": "^2.26.0",
+    "eslint": "^9.13.0",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-import": "^2.31.0",
+    "globals": "^15.11.0",
     "mocha": "^10.0.0",
     "nyc": "^17.0.0",
     "prettier": "^3.0.0",

src/modules/consumer.js

@@ -274,7 +274,4 @@ class Consumer {
   }
 }
 
-/* eslint no-unused-expressions: "off" */
-/* eslint no-sequences: "off" */
-/* eslint arrow-body-style: "off" */
 module.exports = Consumer;

src/modules/hooks/base_hooks.js

@@ -103,7 +103,7 @@ module.exports = class BaseHooks {
 
     const hookPromises = [];
     // This rule intends to restrict it for arrays, but this is a Set which doesn't have a '.map' function to use instead.
-    // eslint-disable-next-line no-restricted-syntax
+
     for (const callback of callbacks) {
       hookPromises.push(runHook(source, eventName, payload, callback));
     }

src/modules/message-parsers.js

@@ -33,19 +33,19 @@ module.exports.in = (msg) => {
  * @param  {object} options amqp.node message options object
  * @return {Buffer}         node.js Buffer object, sent by amqp.node
  */
-/* eslint no-param-reassign: "off" */
 module.exports.out = (content, options) => {
+  let parsedContent = content;
   const falsie = [undefined, null];
   if (!falsie.includes(content) && typeof content !== 'string') {
-    if (content.error instanceof Error) {
-      content.error = serializeError(content.error);
+    if (parsedContent.error instanceof Error) {
+      parsedContent.error = serializeError(parsedContent.error);
     }
     // if content is not a string, we JSONify it (JSON.parse can handle numbers, etc. so we can skip all the checks)
-    content = JSON.stringify(content);
+    parsedContent = JSON.stringify(parsedContent);
     options.contentType = 'application/json';
-  } else if (falsie.includes(content)) {
+  } else if (falsie.includes(parsedContent)) {
     return Buffer.from([]);
   }
 
-  return Buffer.from(content, 'utf-8');
+  return Buffer.from(parsedContent, 'utf-8');
 };

src/modules/producer.js

@@ -205,7 +205,6 @@ class Producer {
    * @param  {object} options message options (persistent, durable, rpc, etc.)
    * @return {Promise}         checkRpc response
    */
-  /* eslint prefer-rest-params: off */
   produce(queue, msg, options) {
     return this.publish(queue, msg, options);
   }
@@ -217,7 +216,6 @@ class Producer {
    * @param  {object} options message options (persistent, durable, rpc, etc.)
    * @return {Promise}         checkRpc response
    */
-  /* eslint no-param-reassign: "off" */
   async publish(queue, msg, options) {
     // default options are persistent and durable because we do not want to miss any outgoing message
     // unless user specify it
@@ -236,6 +234,7 @@ class Producer {
   async _sendToQueue(queue, message, settings, currentRetryNumber) {
     // undefined can't be serialized/buffered :p
     if (!message) {
+      // eslint-disable-next-line no-param-reassign
       message = null;
     }
 
@@ -311,7 +310,4 @@ class Producer {
   }
 }
 
-/* eslint no-unused-expressions: "off" */
-/* eslint no-sequences: "off" */
-/* eslint arrow-body-style: "off" */
 module.exports = Producer;

test/disconnect-spec.js

@@ -5,9 +5,7 @@ const docker = require('./docker');
 const arnavmqConfigurator = require('../src/index');
 const utils = require('../src/modules/utils');
 
-/* eslint func-names: "off" */
-/* eslint prefer-arrow-callback: "off" */
-describe('disconnections', function () {
+describe('disconnections', () => {
   let arnavmq;
 
   beforeEach(() => {

test/producer-consumer-spec.js

@@ -25,9 +25,7 @@ function createFakeChannel() {
   };
 }
 
-/* eslint func-names: "off" */
-/* eslint prefer-arrow-callback: "off" */
-describe('producer/consumer', function () {
+describe('producer/consumer', () => {
   const sandbox = sinon.createSandbox();
   afterEach(() => sandbox.restore());
 

test/rpc-spec.js

@@ -56,7 +56,7 @@ describe('Producer/Consumer RPC messaging:', () => {
           done(error);
         }
         // delete the replyTo so we don't return rpc to client
-        delete properties.replyTo; // eslint-disable-line
+        delete properties.replyTo;
       })
       .then(() =>
         arnavmq.producer