-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nodejs v16 support. #94
base: master
Are you sure you want to change the base?
Conversation
nodejs 16 has reached end-of-life on September last year, and this month it reaches the end of it's maintenance mode as well, removing all official support. In order to keep maintaining the package and update dependencies we reached a point where we need to stop support for it as well.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Failure Feedback 🧐
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
where Configuration options
See more information about the |
.github/workflows/ci.yml
Outdated
@@ -16,7 +16,7 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
node-version: [16.x, 18.x, 20.x] | |||
node-version: [18.x, 20.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please test also version 22
User description
nodejs 16 has reached end-of-life on September last year, and this month it reaches the end of it's maintenance mode as well, removing all official support.
In order to keep maintaining the package and update dependencies we reached a point where we need to stop support for it as well.
PR Type
enhancement, configuration changes
Description
package.json
to version 18 or higher.Changes walkthrough 📝
ci.yml
Update CI workflow to remove Node.js v16 support
.github/workflows/ci.yml
package.json
Update Node.js engine requirement to version 18 or higher
package.json