refactor: remove the crate bstr from the dependency
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jérémy Audiger <jeremy.audiger@icloud.com>
jaudiger
force-pushed
the
remove-bstr-dep
branch
from
116d676 to
a594261
Compare
Contributor
Author
|
On main: 
With this PR: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies a bit the
brioche-runtime-utilscodebase by removing the cratebstrto instead rely exclusively on methods fromstd. The main advantage to use the methods from the standard is there are infaillible which removes a bunch of indirection in the code that were related to error handling (which explains the removal of 100 lines).We still need
bstrbut it's now a transitive dependency.