performance improvements 2 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the observer object into the subs structure for computed signals, eliminating one allocation per computed and removing indirection in the hot path. Previously computed signals required three objects: backing signal, subs (subscriber list), and a separate observer. Now the subs structure serves double duty - it holds both subscriber list fields AND observer fields (compute, firstDep/lastDep, flags, level) when used for a computed.
brnrdog
force-pushed
the
perf-improvements-2
branch
from
92c38da to
12c52a2
Compare
|
🎉 This PR is included in version 1.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR unifies the computed observer and subs into a single structure, eliminating object allocations and pointer indirection in hot paths.
Key Changes
currentComputedSubsfor computeds,currentObserverfor effectsregisterComputed/unregisterComputed(no longer needed)isComputed(subs)checkmainbenchmarksperformance-improvements-2benchmarksBenchmarks comparison
The biggest wins come from eliminating per-computed allocations and reducing pointer chasing during dependency traversal.