Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS-1466 restructure export vcf for copy reasons #8960

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

gbggrant
Copy link
Collaborator

@gbggrant gbggrant commented Aug 22, 2024

Modify GvsExtractCallset so that you can change the value of 'output_gcs_dir' as an input and it won't cause the extract to be re-run (won't invalidate call caching).

Passing run here.
Passing Integration test here.

@gbggrant gbggrant marked this pull request as ready for review August 23, 2024 14:53
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there both a CreateManifest and MakeManifestEntryAndOptionallyCopyOutputs task? Why not just haveMakeManifestEntryAndOptionallyCopyOutputs do the work of both?

scripts/variantstore/wdl/GvsExtractCallset.wdl Outdated Show resolved Hide resolved
@gbggrant gbggrant requested a review from rsasch August 27, 2024 14:27
Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks for the changes!

@gbggrant gbggrant assigned gbggrant and mcovarr and unassigned gbggrant Aug 28, 2024
@gbggrant gbggrant merged commit 09bf732 into ah_var_store Aug 28, 2024
7 of 13 checks passed
@gbggrant gbggrant deleted the gg_VS-1466_RestructureExportVcfForCopyReasons branch August 28, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants